Skip to content

Add missing Test annotations #19742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martint merged 1 commit into from
Nov 14, 2023
Merged

Add missing Test annotations #19742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ protected Optional<DataMappingTestSetup> filterCaseSensitiveDataMappingTestData(
return Optional.of(dataMappingTestSetup);
}

@Test
@Override
public void testNoDataSystemTable()
{
Expand All @@ -287,6 +288,7 @@ protected boolean isColumnNameRejected(Exception exception, String columnName, b
return nullToEmpty(exception.getMessage()).matches(".*Invalid field name \"%s\". Fields must contain the allowed characters, and be at most 300 characters long..*".formatted(columnName.replace("\\", "\\\\")));
}

@Test
@Override // Override because the base test exceeds rate limits per a table
public void testCommentColumn()
{
Expand Down Expand Up @@ -514,6 +516,7 @@ public void testViewDefinitionSystemTable()
onBigQuery(format("DROP VIEW %s.%s", schemaName, viewName));
}

@Test
@Override
public void testShowCreateTable()
{
Expand Down Expand Up @@ -933,6 +936,7 @@ public void testNativeQueryIncorrectSyntax()
.hasMessageContaining("Failed to get schema for query");
}

@Test
@Override
public void testInsertArray()
{
Expand All @@ -943,6 +947,7 @@ public void testInsertArray()
}
}

@Test
@Override
public void testInsertRowConcurrently()
{
Expand Down Expand Up @@ -975,6 +980,7 @@ protected TestTable createTableWithDefaultColumns()
"col_required2 INT64 NOT NULL)");
}

@Test
@Override
public void testCharVarcharComparison()
{
Expand Down