Skip to content

Do not require all sinks to be finished in FileSystemExchange #19736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
Nov 14, 2023
Merged

Do not require all sinks to be finished in FileSystemExchange #19736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ange-filesystem/src/main/java/io/trino/plugin/exchange/filesystem/FileSystemExchange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ public void allRequiredSinksFinished()
return;
}
verify(noMoreSinks, "noMoreSinks is expected to be set");
verify(finishedSinks.keySet().containsAll(allSinks), "all sinks are expected to be finished");
Copy link
Copy Markdown
Member

@findepi findepi Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to finish/close the sinks that weren't finished yet?
can there be a resource leak we if we do not so?

Copy link
Copy Markdown
Member Author

@losipiuk losipiuk Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also though about it. Theoretically yeah - but not the case for exchange implementation we have right now. So I would not extend SPI just yet - we can add the method if we see it is needed for some upcoming exchange impl.

Copy link
Copy Markdown
Member

@sopel39 sopel39 Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can there be a resource leak we if we do not so?

maybe not a leak, but memory could be stalled for a longer time then needed. I would close them if we can

// input is ready, create exchange source handles
exchangeSourceHandlesCreationStarted = true;
exchangeSourceHandlesCreationFuture = stats.getCreateExchangeSourceHandles().record(this::createExchangeSourceHandles);
Expand Down