Remove storing TableSnapshot when multiple tables queried#19732
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Nov 15, 2023
Merged
Remove storing TableSnapshot when multiple tables queried#19732ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
Member
|
Please change PR and commit title to sth like "Remove storing TableSnapshot during metadata queries". otherwise lgtm |
findepi
approved these changes
Nov 14, 2023
findinpath
approved these changes
Nov 14, 2023
pajaks
force-pushed
the
pajaks/snapshot_loading_improvement
branch
from
d7db06b to
9d7807a
Compare
ebyhr
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to reduce memory stress in DeltaLake by remove storing TableSnapshot.
It can be removed when query requests multiple tables and we know that this information will be not used anymore.
Additional context and related issues
Release notes
( x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: