Skip to content

Add missing @Test annotation #19713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Nov 12, 2023
Merged

Add missing @Test annotation #19713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...rino-bigquery/src/test/java/io/trino/plugin/bigquery/BaseBigQueryFailureRecoveryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import io.trino.testing.BaseFailureRecoveryTest;
import io.trino.testing.QueryRunner;
import io.trino.tpch.TpchTable;
import org.junit.jupiter.api.Test;

import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -53,54 +54,62 @@ protected QueryRunner createQueryRunner(
});
}

@Test
@Override
protected boolean areWriteRetriesSupported()
{
return true;
}

@Test
@Override
protected void testAnalyzeTable()
{
// This connector does not support analyze
abort("skipped");
}

@Test
@Override
protected void testDelete()
{
// This connector does not support modifying table rows
abort("skipped");
}

@Test
@Override
protected void testDeleteWithSubquery()
{
// This connector does not support modifying table rows
abort("skipped");
}

@Test
@Override
protected void testMerge()
{
// This connector does not support modifying table rows
abort("skipped");
}

@Test
@Override
protected void testRefreshMaterializedView()
{
// This connector does not support creating materialized views
abort("skipped");
}

@Test
@Override
protected void testUpdate()
{
// This connector does not support modifying table rows
abort("skipped");
}

@Test
@Override
protected void testUpdateWithSubquery()
{
Expand Down
3 changes: 3 additions & 0 deletions ...rino-redshift/src/test/java/io/trino/plugin/redshift/BaseRedshiftFailureRecoveryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import io.trino.plugin.jdbc.BaseJdbcFailureRecoveryTest;
import io.trino.testing.QueryRunner;
import io.trino.tpch.TpchTable;
import org.junit.jupiter.api.Test;

import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -55,13 +56,15 @@ protected QueryRunner createQueryRunner(
});
}

@Test
@Override
protected void testUpdateWithSubquery()
{
assertThatThrownBy(super::testUpdateWithSubquery).hasMessageContaining("Unexpected Join over for-update table scan");
abort("skipped");
}

@Test
@Override
protected void testUpdate()
{
Expand Down