Pushdown predicates fully in BigQuery connector#19699
Conversation
ebyhr
force-pushed
the
ebi/bigquery-filter-pushdown
branch
3 times, most recently
from
bb04138 to
3b23202
Compare
There was a problem hiding this comment.
Otherwise, TestBigQueryAvroConnectorTest.testEmptyProjectionView throws the following error:
io.grpc.StatusRuntimeException: INVALID_ARGUMENT: request failed: Query error: Unrecognized name: regionkey at [1:105]
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
the optional to non-optional API change makes it slightly hard to review but I can't think of ways to avoid that at the moment.
Do we have tests already which result is remainingFilters being present?
ebyhr
force-pushed
the
ebi/bigquery-filter-pushdown
branch
from
3b23202 to
cfb86d5
Compare
We don't have the test as far as I confirmed. Added |
ebyhr
force-pushed
the
ebi/bigquery-filter-pushdown
branch
2 times, most recently
from
0ef7d12 to
7c4999a
Compare
ebyhr
force-pushed
the
ebi/bigquery-filter-pushdown
branch
from
7c4999a to
dc5a296
Compare
|
Rebased on master to resolve conflicts. |
| @Test | ||
| public void testPredicatePushdown() | ||
| { | ||
| testPredicatePushdown("true", "true", true); |
There was a problem hiding this comment.
i was thinking of tests which had two predicates, one which could be pushed down and the other which gets retained.
This one is useful too since it was missing entirely.
There was a problem hiding this comment.
Let's improve the test coverage in follow-up.
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % suggestion (feel free to ignore since it might not provide additional coverage/confidence).
2 participants
Description
Pushdown predicates fully in BigQuery connector
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.