Merged
Conversation
github-actions
bot
added
tests:hive
iceberg
findepi
force-pushed
the
findepi/catch-all-not-found-exceptions-fc5c92
branch
from
29dddbd to
8e1a84f
Compare
losipiuk
reviewed
Nov 13, 2023
| } | ||
| catch (TrinoException e) { | ||
| if (e.getErrorCode().equals(TABLE_NOT_FOUND.toErrorCode())) { | ||
| if (e.getErrorCode().equals(TABLE_NOT_FOUND.toErrorCode()) || e instanceof TableNotFoundException || e instanceof ViewNotFoundException) { |
Member
There was a problem hiding this comment.
why checking exception instance. Can you look check if error code is either TABLE_NOT_FOUND or NOT_FOUND.
Also can we unify? Are there many places which still throw exception with TABLE_NOT_FOUND?
Member
Author
There was a problem hiding this comment.
generally NOT_FOUND feels too broad (eg ColumnNotFoundException, SchemaNotFoundException, ...)
Also can we unify?
this idk
losipiuk
approved these changes
Nov 13, 2023
Table/view not found can be indicated by `TrinoException` with `TABLE_NOT_FOUND` error code, but also by `TableNotFoundException` or `ViewNotFoundException` exceptions (both using `NOT_FOUND` error code). The code catching "not found" exceptions should catch all three.
findepi
force-pushed
the
findepi/catch-all-not-found-exceptions-fc5c92
branch
from
f35cd89 to
1f26b04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table/view not found can be indicated by
TrinoExceptionwithTABLE_NOT_FOUNDerror code, but also byTableNotFoundExceptionorViewNotFoundExceptionexceptions (both usingNOT_FOUNDerror code). The code catching "not found" exceptions should catch all three.