Fix possible race condition in Worker SqlTaskManager#19683
Merged
dain merged 1 commit intotrinodb:masterfrom Nov 13, 2023
Merged
Fix possible race condition in Worker SqlTaskManager#19683dain merged 1 commit intotrinodb:masterfrom
dain merged 1 commit intotrinodb:masterfrom
Conversation
dain
reviewed
Nov 9, 2023
core/trino-main/src/main/java/io/trino/connector/CatalogPruneTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/StaticCatalogManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestSqlTaskManagerRaceWithCatalogPrune.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestSqlTaskManagerRaceWithCatalogPrune.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestSqlTaskManagerRaceWithCatalogPrune.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestSqlTaskManagerRaceWithCatalogPrune.java
Outdated
Show resolved
Hide resolved
e6b325a to
ec236fd
Compare
There is a possible race condition between SqlTaskManager and CatalogPruneTask on workers. Before the catalogs for a Task are set it is possible for a active catalogs from the prune task to arrive, fail to be agumentted by the catalogs of the task, but then prune the catalogs after they are set and loaded. This fix uses a ReadWriteLock to ensure mutual exclusion of task catalog setting and task scanning/pruning.
5871d28 to
8232754
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a possible race condition between SqlTaskManager and
CatalogPruneTask on workers. Before the catalogs for a Task are set it
is possible for a active catalogs from the prune task to arrive, fail to be agumentted by the catalogs of the task, but then prune the catalogs after they are set and loaded. This fix uses a ReadWriteLock to ensure mutual exclusion of task catalog setting and task scanning/pruning.
The included test fails with this in the stack trace without the Read Lock
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: