Ignore internal TableAlreadyExistsException in Iceberg#19650
Merged
ebyhr merged 3 commits intotrinodb:masterfrom Nov 14, 2023
Merged
Ignore internal TableAlreadyExistsException in Iceberg#19650ebyhr merged 3 commits intotrinodb:masterfrom
ebyhr merged 3 commits intotrinodb:masterfrom
Conversation
findinpath
added
the
no-release-notes
findinpath
reviewed
Nov 7, 2023
...berg/src/main/java/io/trino/plugin/iceberg/catalog/hms/AbstractMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
...trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergCreateTableInternalRetry.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Nov 7, 2023
...berg/src/main/java/io/trino/plugin/iceberg/catalog/hms/AbstractMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
pajaks
force-pushed
the
pajaks/iceberg_create_table_retry
branch
from
9f5647d to
e91d86f
Compare
findinpath
approved these changes
Nov 10, 2023
Contributor
findinpath
left a comment
findinpath
left a comment
There was a problem hiding this comment.
Please consider adding handling for Glue either in the scope of this PR or in a follow-up PR.
...berg/src/main/java/io/trino/plugin/iceberg/catalog/hms/AbstractMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
...berg/src/main/java/io/trino/plugin/iceberg/catalog/hms/AbstractMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/hms/TrinoHiveCatalog.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/hms/TrinoHiveCatalog.java
Outdated
Show resolved
Hide resolved
pajaks
force-pushed
the
pajaks/iceberg_create_table_retry
branch
from
e91d86f to
8a67ddc
Compare
pajaks
force-pushed
the
pajaks/iceberg_create_table_retry
branch
from
8a67ddc to
4cb09a0
Compare
findinpath
approved these changes
Nov 13, 2023
findepi
approved these changes
Nov 13, 2023
Member
|
/test-with-secrets sha=4cb09a0f7c64aa6f8d66a6d164df24238456778a |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6848941888 |
Member
Author
|
CI fialures:
|
ebyhr
approved these changes
Nov 14, 2023
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ignore internal TableAlreadyExistsException in CREATE TABLE & register_table on Iceberg connector
Fixes #18308
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: