Conversation
b6466a2 to
c5d57dd
Compare
|
@mosabua great review, thanks! I added a lot more info as a separate commit. This just proves how complex this can get and how important it is to have extensive docs :-) |
|
For k8s, I'll check later if it's easy to mount a persistent volume at /etc/trino/catalog when using the trino helm chart and if we need to document how to do that. |
|
More comments .. very close. We should add some note that with dynamic mode catalogs are managed by the coordinator automatically so it also fully works for scaling clusters .. super cool! .. fyi @dain explained and confirmed this to me. |
|
All comments applied. I tested this locally and all links look good. I've also run Vale this time and there are no issues. |
cefb47f to
2a4c2b7
Compare
mosabua
left a comment
There was a problem hiding this comment.
Looks great now. Users will get excited to see these docs and start testing it out. Once the Hadoop libraries are removed as dependencies we can drop the warning about the object storage connectors.
|
I squashed commits and did some minor corrections btw. |
| - **Default value:** `false` | ||
|
|
||
| Requires [](prop-catalog-store) to be set to `file`. If true, existing catalog | ||
| property files cannot be removed with `DROP CATALOG`, and now new catalog files |
There was a problem hiding this comment.
There's a typo s/now/no
There was a problem hiding this comment.
Dang.. can you fix that in your follow up PR maybe?



Description
Document create/drop catalog with a lot of warnings about known issues.
This adds 3 pages:
There are more existing and undocumented catalog management properties, like
catalog.config-dir, that can be added to the new properties page later.I decided to repeat the same warnings on multiple pages, since they're very important.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: