Skip to content

Test access operations for CREATE OR REPLACE TABLE on Iceberg #19530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Oct 27, 2023
Merged

Test access operations for CREATE OR REPLACE TABLE on Iceberg #19530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergFileOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,26 @@ public void testCreateTable()
.build());
}

@Test
public void testCreateOrReplaceTable()
{
assertFileSystemAccesses("CREATE OR REPLACE TABLE test_create_or_replace (id VARCHAR, age INT)",
ImmutableMultiset.<FileOperation>builder()
.add(new FileOperation(METADATA_JSON, OUTPUT_FILE_CREATE))
.add(new FileOperation(SNAPSHOT, INPUT_FILE_GET_LENGTH))
.add(new FileOperation(SNAPSHOT, INPUT_FILE_NEW_STREAM))
.add(new FileOperation(SNAPSHOT, OUTPUT_FILE_CREATE_OR_OVERWRITE))
.build());
assertFileSystemAccesses("CREATE OR REPLACE TABLE test_create_or_replace (id VARCHAR, age INT)",
ImmutableMultiset.<FileOperation>builder()
.add(new FileOperation(METADATA_JSON, OUTPUT_FILE_CREATE))
.add(new FileOperation(METADATA_JSON, INPUT_FILE_NEW_STREAM))
.add(new FileOperation(SNAPSHOT, INPUT_FILE_GET_LENGTH))
.add(new FileOperation(SNAPSHOT, INPUT_FILE_NEW_STREAM))
.add(new FileOperation(SNAPSHOT, OUTPUT_FILE_CREATE_OR_OVERWRITE))
.build());
}

@Test
public void testCreateTableAsSelect()
{
Expand Down Expand Up @@ -157,6 +177,35 @@ public void testCreateTableAsSelect()
.build());
}

@Test
public void testCreateOrReplaceTableAsSelect()
{
assertFileSystemAccesses(
"CREATE OR REPLACE TABLE test_create_or_replace_as_select AS SELECT 1 col_name",
ImmutableMultiset.<FileOperation>builder()
.addCopies(new FileOperation(METADATA_JSON, OUTPUT_FILE_CREATE), 2)
.add(new FileOperation(METADATA_JSON, INPUT_FILE_NEW_STREAM))
.add(new FileOperation(SNAPSHOT, INPUT_FILE_GET_LENGTH))
.add(new FileOperation(SNAPSHOT, INPUT_FILE_NEW_STREAM))
.add(new FileOperation(SNAPSHOT, OUTPUT_FILE_CREATE_OR_OVERWRITE))
.add(new FileOperation(MANIFEST, OUTPUT_FILE_CREATE_OR_OVERWRITE))
.add(new FileOperation(STATS, OUTPUT_FILE_CREATE))
.build());

assertFileSystemAccesses(
"CREATE OR REPLACE TABLE test_create_or_replace_as_select AS SELECT 1 col_name",
ImmutableMultiset.<FileOperation>builder()
.addCopies(new FileOperation(METADATA_JSON, OUTPUT_FILE_CREATE), 2)
.addCopies(new FileOperation(METADATA_JSON, INPUT_FILE_NEW_STREAM), 2)
.addCopies(new FileOperation(SNAPSHOT, INPUT_FILE_NEW_STREAM), 2)
.addCopies(new FileOperation(SNAPSHOT, INPUT_FILE_GET_LENGTH), 2)
.add(new FileOperation(SNAPSHOT, OUTPUT_FILE_CREATE_OR_OVERWRITE))
.add(new FileOperation(MANIFEST, OUTPUT_FILE_CREATE_OR_OVERWRITE))
.add(new FileOperation(MANIFEST, INPUT_FILE_NEW_STREAM))
.add(new FileOperation(STATS, OUTPUT_FILE_CREATE))
.build());
}

@Test
public void testSelect()
{
Expand Down
38 changes: 38 additions & 0 deletions ...o-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMetastoreAccessOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,23 @@ public void testCreateTable()
.build());
}

@Test
public void testCreateOrReplaceTable()
{
assertMetastoreInvocations("CREATE OR REPLACE TABLE test_create_or_replace (id VARCHAR, age INT)",
ImmutableMultiset.builder()
.add(CREATE_TABLE)
.add(GET_DATABASE)
.add(GET_TABLE)
.build());
assertMetastoreInvocations("CREATE OR REPLACE TABLE test_create_or_replace (id VARCHAR, age INT)",
ImmutableMultiset.builder()
.add(GET_DATABASE)
.add(REPLACE_TABLE)
.add(GET_TABLE)
.build());
}

@Test
public void testCreateTableAsSelect()
{
Expand All @@ -131,6 +148,27 @@ public void testCreateTableAsSelect()
.build());
}

@Test
public void testCreateOrReplaceTableAsSelect()
{
assertMetastoreInvocations(
"CREATE OR REPLACE TABLE test_cortas AS SELECT 1 AS age",
ImmutableMultiset.builder()
.add(GET_DATABASE)
.add(CREATE_TABLE)
.addCopies(GET_TABLE, 4)
.add(REPLACE_TABLE)
.build());

assertMetastoreInvocations(
"CREATE OR REPLACE TABLE test_cortas AS SELECT 1 AS age",
ImmutableMultiset.builder()
.add(GET_DATABASE)
.addCopies(GET_TABLE, 3)
.addCopies(REPLACE_TABLE, 2)
.build());
}

@Test
public void testSelect()
{
Expand Down