Fix syntax in PredicatePushDown#createDynamicFilters arguments list#19528
Merged
wendigo merged 1 commit intotrinodb:masterfrom Oct 26, 2023
Merged
Fix syntax in PredicatePushDown#createDynamicFilters arguments list#19528wendigo merged 1 commit intotrinodb:masterfrom
PredicatePushDown#createDynamicFilters arguments list#19528wendigo merged 1 commit intotrinodb:masterfrom
Conversation
raunaqmorarka
approved these changes
Oct 25, 2023
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
It should probably say "Fix formatting/indentation", not syntax as that sounds like a compiler error
radek-kondziolka
force-pushed
the
rk/fix_syntax
branch
from
26de40a to
2bc8d76
Compare
wendigo
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix syntax in
PredicatePushDown#createDynamicFiltersarguments listRelease notes
(* ) This is not user-visible or is docs only, and no release notes are required.