Skip to content

Skip testing JDBC compatibility for versions 422-424#19509

Merged
wendigo merged 1 commit intotrinodb:masterfrom
wendigo:serafin/jdbc-otel-tests
Oct 26, 2023
Merged

Skip testing JDBC compatibility for versions 422-424#19509
wendigo merged 1 commit intotrinodb:masterfrom
wendigo:serafin/jdbc-otel-tests

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented Oct 24, 2023

This not work with the current open telemetry being a dependency for the JDBC compatibility module

Copy link
Copy Markdown
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we need to make the script more complex.

it should be fine to replace grep -vx 404 with
grep -vx '404\|42[234]'

@wendigo wendigo force-pushed the serafin/jdbc-otel-tests branch from 268914f to 10c4b09 Compare October 25, 2023 15:50
@wendigo wendigo requested a review from findepi October 25, 2023 15:50
@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Oct 25, 2023

@findepi PTAL

@wendigo wendigo merged commit 04e350c into trinodb:master Oct 26, 2023
@wendigo wendigo deleted the serafin/jdbc-otel-tests branch October 26, 2023 13:06
@github-actions github-actions bot added this to the 431 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants