Skip to content

Document the new JDBC legacyPreparedStatements flag#19502

Merged
mosabua merged 2 commits intotrinodb:masterfrom
lpoulain:document-jdbc-legacy-prepared-statements
Oct 24, 2023
Merged

Document the new JDBC legacyPreparedStatements flag#19502
mosabua merged 2 commits intotrinodb:masterfrom
lpoulain:document-jdbc-legacy-prepared-statements

Conversation

@lpoulain
Copy link
Copy Markdown
Member

@lpoulain lpoulain commented Oct 23, 2023

Description

Docs for #19022

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add "Defaults to ??" in the description.

@github-actions github-actions bot added the docs label Oct 23, 2023
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want this code level info .. maybe .. given its the JDBC driver. What do you think @electrum ?

Copy link
Copy Markdown
Member

@mosabua mosabua Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to get an opinion from @electrum to see if this kind of Java code level doc is desired for the JDBC driver docs. I can see arguments for yes and no..

Maybe its best to make sure this kind of stuff is in the javadocs at least so developers find out about it where they work? Wdyt about that idea @lpoulain ?

@lpoulain lpoulain force-pushed the document-jdbc-legacy-prepared-statements branch from fc01508 to b56a5a7 Compare October 23, 2023 21:19
Co-authored-by: Manfred Moser <manfred@simpligility.ca>
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Oct 24, 2023

I am merging this so that we have docs for the already merged code. If we end up renaming we just need to update code and docs.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. If we rename and/or want Java method info we can do a separate follow up.

@mosabua mosabua merged commit 1030a66 into trinodb:master Oct 24, 2023
@github-actions github-actions bot added this to the 431 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants