Add regression test for sort elimination#19496
Merged
martint merged 2 commits intotrinodb:masterfrom Oct 25, 2023
Merged
Conversation
martint
reviewed
Oct 25, 2023
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestEliminateSorts.java
Outdated
Show resolved
Hide resolved
…ns/TestEliminateSorts.java Co-authored-by: Martin Traverso <mtraverso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regression test for #19387
Additional context and related issues
Sort elimination optimization was removed in #19387 because that optimization could produce a wrongly sorted query result. This PR adds a test case to prevent future regression.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.