Increase split processing config parameters#19487
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Oct 26, 2023
Merged
Increase split processing config parameters#19487raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
radek-kondziolka
approved these changes
Oct 23, 2023
raunaqmorarka
approved these changes
Oct 23, 2023
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
Please make sure that any documentation around these properties gets an update and add release notes entry to the PR description.
core/trino-main/src/main/java/io/trino/execution/TaskManagerConfig.java
Outdated
Show resolved
Hide resolved
Improve query performance with easy to process splits by increasing the number of splits assigned.
Contributor
|
hi, @Dith3r . Links cannot be opened (http 404). Can you fix them (may need to make them public). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve query performance with easy to process splits by increasing the number of splits assigned, and makes initial worker split concurrency two times higher, but much slower to be adjusted (increased) based on memory utilization.
Salesforce benchmark:
c_sales.pdf
Hive/parquet/part:
c_hive_par_part.pdf
Hive/parquet/unpart:
c_hive_par_unpart.pdf
Iceberg/parquet/part:
c_iceberg_par_part.pdf
Iceberg/parquet/unpart:
c_iceberg_par_unpart.pdf
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: