Merged
Conversation
The synthetic dictionary, rle, and lazy blocks require special handling in the codebase, and new synthetic blocks cannot reasonable be added without updating the existing code. This commit blocks direct extensions of Block, only allowing extensions to ValueBlock. Seal Block interface Mark ValueBlock interface non-sealed Mark all current ValueBlock implementations as final
electrum
approved these changes
Oct 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The synthetic dictionary, rle, and lazy blocks require special handling
in the codebase, and new synthetic blocks cannot reasonable be added
without updating the existing code. This commit blocks direct extensions
of Block, only allowing extensions to ValueBlock.
Major changes:
BlockinterfaceValueBlockinterfacenon-sealedValueBlockimplementations asfinalThis is part of Project Hummingbird #14237
Release notes
(X) Release notes are required, with the following suggested text: