Skip to content

Add revapi rules after 430 release #19476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Oct 21, 2023
Merged

Add revapi rules after 430 release #19476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions core/trino-spi/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,95 @@
<old>method void io.trino.spi.type.AbstractIntType::checkValueValid(long)</old>
<new>method void io.trino.spi.type.AbstractIntType::checkValueValid(long)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
Copy link
Copy Markdown
Member

@findepi findepi Oct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revapi is smart. not a dumb "return type changed".

<old>method io.trino.spi.block.Block io.trino.spi.block.ArrayBlock::copyPositions(int[], int, int)</old>
<new>method io.trino.spi.block.ArrayBlock io.trino.spi.block.ArrayBlock::copyPositions(int[], int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.ArrayBlock::copyRegion(int, int)</old>
<new>method io.trino.spi.block.ArrayBlock io.trino.spi.block.ArrayBlock::copyRegion(int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.ArrayBlock::getRegion(int, int)</old>
<new>method io.trino.spi.block.ArrayBlock io.trino.spi.block.ArrayBlock::getRegion(int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.ArrayBlock::getSingleValueBlock(int)</old>
<new>method io.trino.spi.block.ArrayBlock io.trino.spi.block.ArrayBlock::getSingleValueBlock(int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.MapBlock::copyPositions(int[], int, int)</old>
<new>method io.trino.spi.block.MapBlock io.trino.spi.block.MapBlock::copyPositions(int[], int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.MapBlock::copyRegion(int, int)</old>
<new>method io.trino.spi.block.MapBlock io.trino.spi.block.MapBlock::copyRegion(int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.MapBlock::getRegion(int, int)</old>
<new>method io.trino.spi.block.MapBlock io.trino.spi.block.MapBlock::getRegion(int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.MapBlock::getSingleValueBlock(int)</old>
<new>method io.trino.spi.block.MapBlock io.trino.spi.block.MapBlock::getSingleValueBlock(int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.RowBlock::copyPositions(int[], int, int)</old>
<new>method io.trino.spi.block.RowBlock io.trino.spi.block.RowBlock::copyPositions(int[], int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.RowBlock::copyRegion(int, int)</old>
<new>method io.trino.spi.block.RowBlock io.trino.spi.block.RowBlock::copyRegion(int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.RowBlock::getRegion(int, int)</old>
<new>method io.trino.spi.block.RowBlock io.trino.spi.block.RowBlock::getRegion(int, int)</new>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.RowBlock::getSingleValueBlock(int)</old>
<new>method io.trino.spi.block.RowBlock io.trino.spi.block.RowBlock::getSingleValueBlock(int)</new>
</item>
<item>
<code>java.method.removed</code>
<old>method int io.trino.spi.block.VariableWidthBlock::bytesCompare(int, int, int, io.airlift.slice.Slice, int, int)</old>
</item>
<item>
<code>java.method.removed</code>
<old>method boolean io.trino.spi.block.VariableWidthBlock::bytesEqual(int, int, io.airlift.slice.Slice, int, int)</old>
</item>
<item>
<code>java.method.removed</code>
<old>method int io.trino.spi.block.VariableWidthBlock::compareTo(int, int, int, io.trino.spi.block.Block, int, int, int)</old>
</item>
<item>
<code>java.method.removed</code>
<old>method boolean io.trino.spi.block.VariableWidthBlock::equals(int, int, io.trino.spi.block.Block, int, int, int)</old>
</item>
<item>
<code>java.method.returnTypeChangedCovariantly</code>
<old>method io.trino.spi.block.Block io.trino.spi.block.VariableWidthBlock::getSingleValueBlock(int)</old>
<new>method io.trino.spi.block.VariableWidthBlock io.trino.spi.block.VariableWidthBlock::getSingleValueBlock(int)</new>
</item>
<item>
<code>java.method.removed</code>
<old>method long io.trino.spi.block.VariableWidthBlock::hash(int, int, int)</old>
</item>
<item>
<code>java.method.removed</code>
<old>method void io.trino.spi.block.VariableWidthBlock::writeSliceTo(int, int, int, io.airlift.slice.SliceOutput)</old>
</item>
</differences>
</revapi.differences>
</analysisConfiguration>
Expand Down