Skip to content

Add missing @Test annotation to overriden test for HiveGlueMetastore #19465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 3 commits into from
Oct 20, 2023
Merged

Add missing @Test annotation to overriden test for HiveGlueMetastore #19465

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af02877
Add missing @Test annotation to overriden test for HiveGlueMetastore
wendigo Oct 20, 2023
52d618c
Merge two @BeforeAll methods to ensure proper initialization
wendigo Oct 20, 2023
f10dbfe
Disable non-supported test case for Glue
wendigo Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ...n/trino-hive/src/test/java/io/trino/plugin/hive/metastore/glue/TestHiveGlueMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@
import static org.apache.hadoop.hive.metastore.TableType.VIRTUAL_VIEW;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.junit.jupiter.api.Assumptions.abort;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;

Expand Down Expand Up @@ -212,11 +213,7 @@ public void initialize()
// uncomment to get extra AWS debug information
// Logging logging = Logging.initialize();
// logging.setLevel("com.amazonaws.request", Level.DEBUG);
}

@BeforeAll
public void setup()
{
metastore = new HiveMetastoreClosure(metastoreClient);
glueClient = AWSGlueAsyncClientBuilder.defaultClient();
}
Expand Down Expand Up @@ -978,6 +975,13 @@ public void testGetPartitionsFilterUnsupported()
testGetPartitionsFilterUnsupported(CREATE_TABLE_COLUMNS_PARTITIONED_TIMESTAMP, Domain.notNull(TimestampType.TIMESTAMP_MILLIS), "2022-07-11 01:02:03.123");
}

@Test
@Override
public void testPartitionSchemaMismatch()
{
abort("tests using existing tables are not supported");
}

private void testGetPartitionsFilterUnsupported(List<ColumnMetadata> columnMetadata, Domain domain, String partitionValue)
throws Exception
{
Expand Down Expand Up @@ -1333,6 +1337,7 @@ public void testInvalidColumnStatisticsMetadata()
}
}

@Test
@Override
public void testPartitionColumnProperties()
{
Expand Down