Add fileModifiedTime in DeltaLakeSplit Object methods#19425
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Oct 18, 2023
Merged
Add fileModifiedTime in DeltaLakeSplit Object methods#19425ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
Merged
raunaqmorarka
approved these changes
Oct 17, 2023
ebyhr
approved these changes
Oct 18, 2023
findepi
reviewed
Oct 23, 2023
| .add("length", length) | ||
| .add("fileSize", fileSize) | ||
| .add("rowCount", fileRowCount) | ||
| .add("fileModifiedTime", fileModifiedTime) |
Member
There was a problem hiding this comment.
I don't think it's helpful in toString.
too verbose imo.
| public int hashCode() | ||
| { | ||
| return Objects.hash(path, start, length, fileSize, fileRowCount, deletionVector, statisticsPredicate, partitionKeys); | ||
| return Objects.hash(path, start, length, fileSize, fileRowCount, fileModifiedTime, deletionVector, statisticsPredicate, partitionKeys); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to #18719 (comment)
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: