Refactor stage output data size estimation#19414
Merged
losipiuk merged 2 commits intotrinodb:masterfrom Oct 17, 2023
Merged
Conversation
findepi
approved these changes
Oct 16, 2023
Comment on lines
243
to
245
Member
There was a problem hiding this comment.
Make it into a @Provides on the containing class (CoordinatorModule). Should be no need for inner class.
Member
Author
There was a problem hiding this comment.
I know I can do that - but I think it is beneficial for readability to keep all of that together.
core/trino-main/src/main/java/io/trino/server/CoordinatorModule.java
Outdated
Show resolved
Hide resolved
Extract OutputDataSizeEstimator and model current logic as a series of implementations of it wrapped in CompositeOutputDataSizeEstimator.
linzebing
approved these changes
Oct 16, 2023
losipiuk
force-pushed
the
lo/refactor-output-size-estimation
branch
from
bc54097 to
62db142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract OutputDataSizeEstimator and model current logic
as a series of implementations of it wrapped in
CompositeOutputDataSizeEstimator.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.