Skip to content

Fix TestIcebergAbfsConnectorSmokeTest failure #19386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Oct 12, 2023
Merged

Fix TestIcebergAbfsConnectorSmokeTest failure #19386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions ...rino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import io.trino.plugin.hive.metastore.thrift.BridgingHiveMetastore;
import io.trino.testing.QueryRunner;
import org.junit.jupiter.api.Test;
import org.testng.annotations.Parameters;

import java.nio.file.Path;
import java.nio.file.attribute.FileAttribute;
Expand Down Expand Up @@ -51,16 +50,12 @@ public class TestIcebergAbfsConnectorSmokeTest

private HiveHadoop hiveHadoop;

@Parameters({
"hive.hadoop2.azure-abfs-container",
"hive.hadoop2.azure-abfs-account",
"hive.hadoop2.azure-abfs-access-key"})
public TestIcebergAbfsConnectorSmokeTest(String container, String account, String accessKey)
public TestIcebergAbfsConnectorSmokeTest()
{
super(ORC);
this.container = requireNonNull(container, "container is null");
this.account = requireNonNull(account, "account is null");
this.accessKey = requireNonNull(accessKey, "accessKey is null");
this.container = requireNonNull(System.getProperty("hive.hadoop2.azure-abfs-container"), "container is null");
this.account = requireNonNull(System.getProperty("hive.hadoop2.azure-abfs-account"), "account is null");
this.accessKey = requireNonNull(System.getProperty("hive.hadoop2.azure-abfs-access-key"), "accessKey is null");
this.schemaName = "tpch_" + format.name().toLowerCase(ENGLISH);
this.bucketName = "test-iceberg-smoke-test-" + randomNameSuffix();
}
Expand Down