Fail query when the symlink file contains inexistent paths#19364
Merged
findepi merged 1 commit intotrinodb:masterfrom Oct 12, 2023
Merged
Fail query when the symlink file contains inexistent paths#19364findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
electrum
approved these changes
Oct 12, 2023
electrum
reviewed
Oct 12, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/BackgroundHiveSplitLoader.java
Outdated
Show resolved
Hide resolved
18038c2 to
98a90ac
Compare
98a90ac to
181a536
Compare
pajaks
approved these changes
Oct 12, 2023
findepi
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When dealing with a symlink Hive table which has a
symlink.txtfile containing an inexistent path, fail early with a meaningful exception (similar to what happens in Hive), instead of failing with the bogus exception:Reproduction scenario
Reproduction scenario:
Spin up the product test environment:
Create the tables in Hive:
Create a
symlink.txtfile with the following content:000000_0_copy_1_bad_filedoesn't actually existCopy the
symlink.txtfile totestsymlinkparquetstorage:Query in Hive:
Query in Trino:
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: