Remove default implementation of withoutSmallFileThreshold#19355
Conversation
raunaqmorarka
left a comment
There was a problem hiding this comment.
There can be connectors like mongoDB where we're testing reduction in physical data read due to projection and predicate pushdown but the small file optimization doesn't apply there
|
Can you add a code comment in also, if it's sometimes not needed, and sometimes it is needed, it\d be better not to have default implementation still, and have a no-op impl for connectors where this is suitable |
It looks like this change is fine for now as MongoDb is skipping this test. We can let connectors add no-op implementation if needed later. |
The default implementation did not do anything, which is not suitable for the test.
f541b89 to
64e936d
Compare
|
( just rebased, no other changes ) |
The default implementation did not do anything, which is not suitable for the test.