Apply PrefixObjectNameGeneratorModule in tests#19346
Merged
findepi merged 1 commit intotrinodb:masterfrom Oct 13, 2023
Merged
Conversation
This allows using QueryRunner for manually diagnosing metrics exported via `/metrics`. This way the metrics exported in tests will have same names as ones exported in real deployment.
findepi
added
test
no-release-notes
hashhar
approved these changes
Oct 11, 2023
losipiuk
approved these changes
Oct 11, 2023
wendigo
approved these changes
Oct 11, 2023
findepi
deleted the
findepi/apply-prefixobjectnamegeneratormodule-in-tests-e27d68
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using QueryRunner for manually diagnosing metrics exported via
/metrics. This way the metrics exported in tests will have same names as ones exported in real deployment.