Add support for SQL functions#19308
Merged
electrum merged 2 commits intotrinodb:masterfrom Oct 25, 2023
Merged
Conversation
95ee964 to
847ccdb
Compare
martint
reviewed
Oct 9, 2023
Member
martint
left a comment
There was a problem hiding this comment.
Some initial comments for the first commit.
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/AssignmentStatement.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/AssignmentStatement.java
Outdated
Show resolved
Hide resolved
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/RepeatStatement.java
Outdated
Show resolved
Hide resolved
martint
reviewed
Oct 11, 2023
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutinePlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutinePlanner.java
Outdated
Show resolved
Hide resolved
martint
reviewed
Oct 23, 2023
core/trino-spi/src/main/java/io/trino/spi/function/LanguageFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/LanguageFunctionManager.java
Outdated
Show resolved
Hide resolved
Member
Author
|
I split the first three commits out into #19508 |
d4765b5 to
9443a4f
Compare
Member
|
I split the inline functions commit to #19521 |
dain
reviewed
Oct 25, 2023
core/trino-main/src/main/java/io/trino/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/DropFunctionTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/SqlEnvironmentConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/DatabaseFunctionKey.java
Outdated
Show resolved
Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/DatabaseFunctionSignatureKey.java
Outdated
Show resolved
Hide resolved
58fc0f2 to
7e610d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for inline SQL functions and for persistent SQL functions with
CREATE FUNCTIONandDROP FUNCTION. Functions can be stored using the Memory or Hive connectors.Additional context and related issues
Documentation: #18854
Release notes
(x) Release notes are required, with the following suggested text: