Skip to content

Add support for SQL functions#19308

Merged
electrum merged 2 commits intotrinodb:masterfrom
electrum:functions
Oct 25, 2023
Merged

Add support for SQL functions#19308
electrum merged 2 commits intotrinodb:masterfrom
electrum:functions

Conversation

@electrum
Copy link
Member

@electrum electrum commented Oct 8, 2023

Description

Add support for inline SQL functions and for persistent SQL functions with CREATE FUNCTION and DROP FUNCTION. Functions can be stored using the Memory or Hive connectors.

Additional context and related issues

Documentation: #18854

Release notes

(x) Release notes are required, with the following suggested text:

# General
* Add support for inline SQL functions. ({issue}`19308`)
* Add support for `CREATE FUNCTION` and `DROP FUNCTION`. ({issue}`19308`)

# CLI
* Handle functions when splitting statements. ({issue}`19308`)

@cla-bot cla-bot bot added the cla-signed label Oct 8, 2023
@electrum electrum changed the title Functions Add support for SQL functions Oct 8, 2023
@github-actions github-actions bot added tests:hive hive Hive connector labels Oct 8, 2023
@electrum electrum requested a review from martint October 8, 2023 00:31
@electrum electrum force-pushed the functions branch 5 times, most recently from 95ee964 to 847ccdb Compare October 8, 2023 21:11
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments for the first commit.

@martint martint added the roadmap Top level issues for major efforts in the project label Oct 9, 2023
@electrum
Copy link
Member Author

I split the first three commits out into #19508

@electrum electrum force-pushed the functions branch 2 times, most recently from d4765b5 to 9443a4f Compare October 24, 2023 19:02
@dain
Copy link
Member

dain commented Oct 24, 2023

I split the inline functions commit to #19521

Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last two commits look good

@electrum electrum force-pushed the functions branch 2 times, most recently from 58fc0f2 to 7e610d0 Compare October 25, 2023 19:25
@electrum electrum merged commit b419cab into trinodb:master Oct 25, 2023
@electrum electrum deleted the functions branch October 25, 2023 23:19
@github-actions github-actions bot added this to the 431 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed hive Hive connector roadmap Top level issues for major efforts in the project

Development

Successfully merging this pull request may close these issues.

3 participants