Support OR-ed condition in Delta checkpoint iterator#19240
Closed
ebyhr wants to merge 3 commits intotrinodb:masterfrom
Closed
Support OR-ed condition in Delta checkpoint iterator#19240ebyhr wants to merge 3 commits intotrinodb:masterfrom
ebyhr wants to merge 3 commits intotrinodb:masterfrom
Conversation
github-actions
bot
added
tests:hive
hudi
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/delta-checkpoint-entry-or
branch
from
3ef7456 to
644fb08
Compare
findinpath
reviewed
Oct 18, 2023
Comment on lines
+537
to
+539
| if (parquetPredicate.isPresent() && options.isUseColumnIndex()) { | ||
| return parquetPredicate.get().toParquetFilter(timeZone); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (parquetPredicate.isPresent() && options.isUseColumnIndex()) { | |
| return parquetPredicate.get().toParquetFilter(timeZone); | |
| } | |
| if (options.isUseColumnIndex()) { | |
| return parquetPredicate.flatMap(predicate -> predicate.toParquetFilter(timeZone)); | |
| } |
findinpath
reviewed
Oct 18, 2023
| nullableFilterPredicate = filter; | ||
| } | ||
| else { | ||
| nullableFilterPredicate = FilterApi.or(nullableFilterPredicate, filter); |
Contributor
There was a problem hiding this comment.
Add a corresponding test in TestCheckpointEntryIterator
This was referenced Oct 18, 2023
Member
Author
|
Superceded by #19439 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to #19156
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.