Enforce Client capabilities when Session Authorization is not supported#19217
Merged
phd3 merged 1 commit intotrinodb:masterfrom Oct 18, 2023
Merged
Enforce Client capabilities when Session Authorization is not supported#19217phd3 merged 1 commit intotrinodb:masterfrom
phd3 merged 1 commit intotrinodb:masterfrom
Conversation
phd3
approved these changes
Oct 5, 2023
Member
|
Thanks @b-slim, could you please squash commit and shorten the commit message to something like: I tried doing it myself, but access issues on your branch. There's a commit here:https://github.com/phd3/trino/commits/pr19217 |
Adds SESSION_AUTHORIZATION to ClientCapabilities, so that the client side support for this feature can be identified using the headers sent to Trino.
338a827 to
82793c9
Compare
Contributor
Author
|
Thanks @phd3 done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given that
SET SESSION AUTHORIZATIONrequires a client side changes we need to enforce and fail any client missing this capability.Additional context and related issues
This Pull request is a follow up to #16067
Fixes Comment #16067 (comment)
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: