Skip to content

Enforce Client capabilities when Session Authorization is not supported#19217

Merged
phd3 merged 1 commit intotrinodb:masterfrom
b-slim:enforce_client_capabilities
Oct 18, 2023
Merged

Enforce Client capabilities when Session Authorization is not supported#19217
phd3 merged 1 commit intotrinodb:masterfrom
b-slim:enforce_client_capabilities

Conversation

@b-slim
Copy link
Copy Markdown
Contributor

@b-slim b-slim commented Oct 1, 2023

Description

Given that SET SESSION AUTHORIZATION requires a client side changes we need to enforce and fail any client missing this capability.

Additional context and related issues

This Pull request is a follow up to #16067
Fixes Comment #16067 (comment)

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text:

# General
* Clients with version less than this release will fail when issuing commands `RESET / SET SESSION AUTHORIZIATION`. ({issue}`19217 `)

@cla-bot cla-bot bot added the cla-signed label Oct 1, 2023
@b-slim b-slim requested a review from phd3 October 1, 2023 15:30
@phd3
Copy link
Copy Markdown
Member

phd3 commented Oct 5, 2023

Thanks @b-slim, could you please squash commit and shorten the commit message to something like:

    Cleanly reject session authorization queries for unsupported clients

    Adds SESSION_AUTHORIZATION to ClientCapabilities, so that the
    client side support for this feature can be identified using
    the headers sent to Trino.

I tried doing it myself, but access issues on your branch. There's a commit here:https://github.com/phd3/trino/commits/pr19217

Adds SESSION_AUTHORIZATION to ClientCapabilities, so that the
client side support for this feature can be identified using
the headers sent to Trino.
@b-slim b-slim force-pushed the enforce_client_capabilities branch from 338a827 to 82793c9 Compare October 10, 2023 00:39
@b-slim
Copy link
Copy Markdown
Contributor Author

b-slim commented Oct 10, 2023

Thanks @phd3 done

@phd3 phd3 merged commit 60b9fc1 into trinodb:master Oct 18, 2023
@github-actions github-actions bot added this to the 430 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants