Disallow null offset in lead/lag window functions#19015
Merged
martint merged 1 commit intotrinodb:masterfrom Oct 24, 2023
Merged
Disallow null offset in lead/lag window functions#19015martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
dc336a8 to
383ab1f
Compare
Per the SQL spec, the offset cannot be null.
<lead or lag function> ::=
<lead or lag> <left paren> <lead or lag extent>
[ <comma> <offset> [ <comma> <default expression> ] ] <right paren>
[ <window function null treatment> ]
<offset> ::=
<unsigned integer>
Moreover, it should be a constant value, but this is not being addressed in this change.
383ab1f to
8614ade
Compare
dain
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the SQL spec, the offset cannot be null.
Moreover, it should be a constant value, but this is not being addressed in this change.
Fixes #19003
Release notes
(x) Release notes are required, with the following suggested text: