Skip to content

Change MAP and ROW stack types#18948

Merged
dain merged 22 commits intotrinodb:masterfrom
dain:map-row-stack-types
Oct 12, 2023
Merged

Change MAP and ROW stack types#18948
dain merged 22 commits intotrinodb:masterfrom
dain:map-row-stack-types

Conversation

@dain
Copy link
Copy Markdown
Member

@dain dain commented Sep 6, 2023

Description

This PR changes MAP and ROW stack types to be SqlMap and SqlRow respectively. The new types do not extend block, and simply wrappers around the underlying column blocks. Both of these value classes have accessors for the underlying blocks and the offset into the blocks.

This PR contains a number of cleanup commit to simplify this conversion, and it also contains some minor fixes I found while making this change.

This is part of Project Hummingbird

Release notes

( ) Release notes are required, with the following suggested text:

# Section
* The Java stack type for a `MAP` value is now `SqlMap`, which does not implement `Block`. ({issue}`18948`)
* The Java stack type for a `ROW` value is now `SqlRow`, which does not implement `Block`. ({issue}`18948`)

@dain dain requested review from electrum and martint September 6, 2023 21:21
@cla-bot cla-bot bot added the cla-signed label Sep 6, 2023
@github-actions github-actions bot added tests:hive iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector mongodb MongoDB connector labels Sep 6, 2023
@dain dain mentioned this pull request Sep 6, 2023
19 tasks
@dain dain force-pushed the map-row-stack-types branch from 08fd420 to 81de85e Compare September 7, 2023 23:17
@dain dain force-pushed the map-row-stack-types branch 2 times, most recently from f396f3e to c0bff0d Compare September 16, 2023 19:20
@dain dain force-pushed the map-row-stack-types branch from c0bff0d to 381eb19 Compare October 10, 2023 18:44
@dain dain force-pushed the map-row-stack-types branch from 381eb19 to 8c1c6c1 Compare October 12, 2023 04:57
@dain dain merged commit e026add into trinodb:master Oct 12, 2023
@dain dain deleted the map-row-stack-types branch October 12, 2023 06:23
@github-actions github-actions bot added this to the 430 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bigquery BigQuery connector cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector mongodb MongoDB connector

Development

Successfully merging this pull request may close these issues.

2 participants