Change MAP and ROW stack types#18948
Merged
dain merged 22 commits intotrinodb:masterfrom Oct 12, 2023
Merged
Conversation
08fd420 to
81de85e
Compare
f396f3e to
c0bff0d
Compare
c0bff0d to
381eb19
Compare
electrum
approved these changes
Oct 12, 2023
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/rcfile/ValidationHash.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/block/SqlRowBlockEncoding.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeParquetStatisticsUtils.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/MapConstructor.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/util/StructuralTestUtil.java
Outdated
Show resolved
Hide resolved
Operators used arguments named left and right, but the arguments were in the wrong order. This order was consistent, so this is not a bug.
SqlMap can now be built directly from key and value blocks without copying.
381eb19 to
8c1c6c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
MAPandROWstack types to beSqlMapandSqlRowrespectively. The new types do not extend block, and simply wrappers around the underlying column blocks. Both of these value classes have accessors for the underlying blocks and the offset into the blocks.This PR contains a number of cleanup commit to simplify this conversion, and it also contains some minor fixes I found while making this change.
This is part of Project Hummingbird
Release notes
( ) Release notes are required, with the following suggested text: