Fix BigQuery metadata listing for ambiguous table names#18927
Merged
wendigo merged 1 commit intotrinodb:masterfrom Sep 5, 2023
Merged
Fix BigQuery metadata listing for ambiguous table names#18927wendigo merged 1 commit intotrinodb:masterfrom
wendigo merged 1 commit intotrinodb:masterfrom
Conversation
wendigo
force-pushed
the
serafin/fix-bq
branch
from
bee8d94 to
4f740a0
Compare
hashhar
approved these changes
Sep 5, 2023
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % change commit message to Since c9fa5ffe64439cae24070628275d22d1ccbaa897 .....
Since c9fa5ff metadata listing does not longer call getTableHandle. Listing columns or tables in BigQuery connector is not failing since for ambiguous tables as they are filtered out.
wendigo
force-pushed
the
serafin/fix-bq
branch
from
4f740a0 to
bde96c3
Compare
Contributor
Author
|
@hashhar done |
Member
|
/test-with-secrets sha=bde96c3a4b4d44109649a64801fdeb928113dfde |
ebyhr
approved these changes
Sep 5, 2023
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6084072239 |
Contributor
Author
|
Damn, closed it by accident. I hope that run with secrets workflow won't be restarted :) |
Contributor
Author
|
This particular test that was linked here was successful so I'm merging this change as it-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #18730 metadata listing does not longer call getTableHandle so when listing columns or tables in BigQuery connector, ambiguous objects are filtered out.
Fixes #18889 and makes master happy :)
Description
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.