Add causing exception to Hudi metadata parsing error#18890
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Sep 1, 2023
Merged
Add causing exception to Hudi metadata parsing error#18890ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Attila Tóth.
|
d1400a5 to
1050876
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Attila Tóth.
|
1050876 to
00f45ab
Compare
00f45ab to
7294b8d
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Attila Tóth.
|
7294b8d to
6dd030e
Compare
findepi
approved these changes
Sep 1, 2023
ebyhr
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In case of a Hudi metadata corruption during reading replace commits, the exact exception is not logged in the error message, making it difficult to diagnose the actual problem. This PR aims to fix that with a very small code extension.
Additional context and related issues
When the filesystem view for a Hudi table is assembled in the Trino Hudi connector, replace commits need to be collected so that data is not read multiple times by the system. During this operation Hudi metadata for these commits is accessed and when it is not readable, the error message does not tell the actual reason. This PR is aiming to fix that.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: