Use tracing for testing DatabaseMetaData ConnectorMetadata invocations #18849
Merged
findepi merged 5 commits intotrinodb:masterfrom Aug 30, 2023
Merged
Use tracing for testing DatabaseMetaData ConnectorMetadata invocations #18849findepi merged 5 commits intotrinodb:masterfrom
findepi merged 5 commits intotrinodb:masterfrom
Conversation
findepi
added
test
no-release-notes
ebyhr
approved these changes
Aug 30, 2023
Refactor `TrinoDatabaseMetaData` to leverage tracing like `TestInformationSchemaConnector` was changed in bdc2799. The differences in expected counts in the test come from the fact how the counting was done previously. For example `MockConnectorMetadata.listTables` calls `listSchemaNames` before `listTables`, so this single metadata call was being recorded as both `listSchemaNames` and `listTables` (zero or more times).
All usages now use the tracing-based approach (`TracingConnectorMetadata`).
findepi
force-pushed
the
findepi/test-db-md
branch
from
e093762 to
136ee7a
Compare
github-actions
bot
added
tests:hive
iceberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
TrinoDatabaseMetaDatato leverage tracing likeTestInformationSchemaConnectorwas changed inbdc2799.
The differences in expected counts in the test come from the fact how
the counting was done previously. For example
MockConnectorMetadata.listTablescallslistSchemaNamesbeforelistTables, so this single metadata call was being recorded as bothlistSchemaNamesandlistTables(zero or more times).Fixes #18595