Patch Ignite client to work with JDK21#18833
Merged
wendigo merged 3 commits intotrinodb:masterfrom Aug 29, 2023
Merged
Conversation
nineinchnick
commented
Aug 28, 2023
lib/trino-ignite-patched/src/main/java/org/apache/ignite/shaded/internal/util/GridUnsafe.java
Outdated
Show resolved
Hide resolved
Contributor
|
@nineinchnick please split this change into three commits:
|
wendigo
reviewed
Aug 28, 2023
lib/trino-ignite-patched/src/main/java/org/apache/ignite/shaded/internal/util/GridUnsafe.java
Outdated
Show resolved
Hide resolved
Member
Author
The commit with the original |
Contributor
|
@nineinchnick original, formatted and fixed (assert) |
02dd6a0 to
e7e2189
Compare
Contributor
|
There is a typo in the second commit: Path instead of patch. Please also change third commit title to Other than that LGTM. I'll merge when you push the updated commit titles. |
e7e2189 to
f5c0b73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per the discussion in apache/ignite#10764, the earliest we can expect a new release is by the end of the current year. Apply the patch to the current Ignite version so Trino can be built on JDK 21.
Same approach as in #13108
Tested manually using Temurin 21 Early Access.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: