Skip to content

Remove obsolete config/session property #18827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
Aug 28, 2023
Merged

Remove obsolete config/session property #18827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ public final class SystemSessionProperties
public static final String USE_EXACT_PARTITIONING = "use_exact_partitioning";
public static final String USE_COST_BASED_PARTITIONING = "use_cost_based_partitioning";
public static final String FORCE_SPILLING_JOIN = "force_spilling_join";
public static final String FAULT_TOLERANT_EXECUTION_FORCE_PREFERRED_WRITE_PARTITIONING_ENABLED = "fault_tolerant_execution_force_preferred_write_partitioning_enabled";
public static final String PAGE_PARTITIONING_BUFFER_POOL_SIZE = "page_partitioning_buffer_pool_size";
public static final String FLAT_GROUP_BY_HASH = "flat_group_by_hash";

Expand Down Expand Up @@ -1063,11 +1062,6 @@ public SystemSessionProperties(
"Force the usage of spliing join operator in favor of the non-spilling one, even if spill is not enabled",
featuresConfig.isForceSpillingJoin(),
false),
booleanProperty(
FAULT_TOLERANT_EXECUTION_FORCE_PREFERRED_WRITE_PARTITIONING_ENABLED,
"Force preferred write partitioning for fault tolerant execution",
queryManagerConfig.isFaultTolerantExecutionForcePreferredWritePartitioningEnabled(),
true),
integerProperty(PAGE_PARTITIONING_BUFFER_POOL_SIZE,
"Maximum number of free buffers in the per task partitioned page buffer pool. Setting this to zero effectively disables the pool",
taskManagerConfig.getPagePartitioningBufferPoolSize(),
Expand Down Expand Up @@ -1915,11 +1909,6 @@ public static boolean isForceSpillingOperator(Session session)
return session.getSystemProperty(FORCE_SPILLING_JOIN, Boolean.class);
}

public static boolean isFaultTolerantExecutionForcePreferredWritePartitioningEnabled(Session session)
{
return session.getSystemProperty(FAULT_TOLERANT_EXECUTION_FORCE_PREFERRED_WRITE_PARTITIONING_ENABLED, Boolean.class);
}

public static int getPagePartitioningBufferPoolSize(Session session)
{
return session.getSystemProperty(PAGE_PARTITIONING_BUFFER_POOL_SIZE, Integer.class);
Expand Down
13 changes: 1 addition & 12 deletions core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"query.max-pending-splits-per-node",
"query.queue-config-file",
"experimental.big-query-initial-hash-partitions",
"experimental.fault-tolerant-execution-force-preferred-write-partitioning-enabled",
"experimental.max-concurrent-big-queries",
"experimental.max-queued-big-queries",
"query-manager.initialization-required-workers",
Expand Down Expand Up @@ -1010,18 +1011,6 @@ public QueryManagerConfig setFaultTolerantExecutionRuntimeAdaptivePartitioningMa
return this;
}

public boolean isFaultTolerantExecutionForcePreferredWritePartitioningEnabled()
{
return faultTolerantExecutionForcePreferredWritePartitioningEnabled;
}

@Config("experimental.fault-tolerant-execution-force-preferred-write-partitioning-enabled")
public QueryManagerConfig setFaultTolerantExecutionForcePreferredWritePartitioningEnabled(boolean faultTolerantExecutionForcePreferredWritePartitioningEnabled)
{
this.faultTolerantExecutionForcePreferredWritePartitioningEnabled = faultTolerantExecutionForcePreferredWritePartitioningEnabled;
return this;
}

public double getFaultTolerantExecutionMinSourceStageProgress()
{
return faultTolerantExecutionMinSourceStageProgress;
Expand Down
3 changes: 0 additions & 3 deletions core/trino-main/src/test/java/io/trino/execution/TestQueryManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ public void testDefaults()
.setFaultTolerantExecutionRuntimeAdaptivePartitioningEnabled(false)
.setFaultTolerantExecutionRuntimeAdaptivePartitioningMaxTaskSize(DataSize.of(12, GIGABYTE))
.setFaultTolerantExecutionRuntimeAdaptivePartitioningPartitionCount(FAULT_TOLERANT_EXECUTION_MAX_PARTITION_COUNT_LIMIT)
.setFaultTolerantExecutionForcePreferredWritePartitioningEnabled(true)
.setFaultTolerantExecutionMinSourceStageProgress(0.2)
.setFaultTolerantExecutionSmallStageEstimationEnabled(true)
.setFaultTolerantExecutionSmallStageEstimationThreshold(DataSize.of(20, GIGABYTE))
Expand Down Expand Up @@ -177,7 +176,6 @@ public void testExplicitPropertyMappings()
.put("fault-tolerant-execution-runtime-adaptive-partitioning-enabled", "true")
.put("fault-tolerant-execution-runtime-adaptive-partitioning-partition-count", "888")
.put("fault-tolerant-execution-runtime-adaptive-partitioning-max-task-size", "18GB")
.put("experimental.fault-tolerant-execution-force-preferred-write-partitioning-enabled", "false")
.put("fault-tolerant-execution-min-source-stage-progress", "0.3")
.put("query.max-writer-task-count", "101")
.put("fault-tolerant-execution-small-stage-estimation-enabled", "false")
Expand Down Expand Up @@ -249,7 +247,6 @@ public void testExplicitPropertyMappings()
.setFaultTolerantExecutionRuntimeAdaptivePartitioningEnabled(true)
.setFaultTolerantExecutionRuntimeAdaptivePartitioningPartitionCount(888)
.setFaultTolerantExecutionRuntimeAdaptivePartitioningMaxTaskSize(DataSize.of(18, GIGABYTE))
.setFaultTolerantExecutionForcePreferredWritePartitioningEnabled(false)
.setFaultTolerantExecutionMinSourceStageProgress(0.3)
.setFaultTolerantExecutionSmallStageEstimationEnabled(false)
.setFaultTolerantExecutionSmallStageEstimationThreshold(DataSize.of(6, GIGABYTE))
Expand Down