Skip to content

Move slow Delta Lake product tests to integration tests#18803

Merged
ebyhr merged 1 commit intomasterfrom
ebi/delta-move-pt
Sep 1, 2023
Merged

Move slow Delta Lake product tests to integration tests#18803
ebyhr merged 1 commit intomasterfrom
ebi/delta-move-pt

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Aug 24, 2023 •
edited by findepi
Loading

Description

Move slow Delta Lake product tests to integration tests.

testDeltaColumnMappingModeAllDataTypes [id, true]  took 1 minutes and 4 seconds
testDeltaColumnMappingModeAllDataTypes [id, false]  took 1 minutes and 8 seconds
testDeltaColumnMappingModeAllDataTypes [none, true]  took 1 minutes and 12 seconds
testDeltaColumnMappingModeAllDataTypes [none, false]  took 1 minutes and 18 seconds
testDeltaColumnMappingModeAllDataTypes [name, true]  took 1 minutes and 19 seconds
testDeltaColumnMappingModeAllDataTypes [name, false]  took 1 minutes and 24 seconds
testOptimizeProcedureColumnMappingMode [name, true]  took 1 minutes and 29 seconds
testOptimizeProcedureColumnMappingMode [name, false]  took 1 minutes and 36 seconds
testOptimizeProcedureColumnMappingMode [none, true]  took 1 minutes and 38 seconds
testOptimizeProcedureColumnMappingMode [none, false]  took 1 minutes and 42 seconds
testOptimizeProcedureColumnMappingMode [id, false]  took 1 minutes and 44 seconds
testOptimizeProcedureColumnMappingMode [id, true]  took 1 minutes and 45 seconds
testSupportedNonPartitionedColumnMappingWrites [none, true]  took 2 minutes and 15 seconds
testSupportedNonPartitionedColumnMappingWrites [none, false]  took 2 minutes and 16 seconds
testSupportedNonPartitionedColumnMappingWrites [name, true]  took 2 minutes and 17 seconds
testSupportedNonPartitionedColumnMappingWrites [id, false]  took 2 minutes and 18 seconds
testSupportedNonPartitionedColumnMappingWrites [name, false]  took 2 minutes and 20 seconds
testSupportedNonPartitionedColumnMappingWrites [id, true]  took 2 minutes and 21 seconds
testSupportedPartitionedColumnMappingWrites [none, false]  took 2 minutes and 14 seconds
testSupportedPartitionedColumnMappingWrites [id, false]  took 2 minutes and 16 seconds
testSupportedPartitionedColumnMappingWrites [none, true]  took 2 minutes and 17 seconds
testSupportedPartitionedColumnMappingWrites [name, false]  took 2 minutes and 18 seconds
testSupportedPartitionedColumnMappingWrites [name, true]  took 2 minutes and 19 seconds
testSupportedPartitionedColumnMappingWrites [id, true]  took 2 minutes and 20 seconds

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Relates to #18805

@cla-bot cla-bot bot added the cla-signed label Aug 24, 2023
@github-actions github-actions bot added tests:hive delta-lake Delta Lake connector labels Aug 24, 2023
@ebyhr ebyhr force-pushed the ebi/delta-move-pt branch from 3b8aa51 to d786ecf Compare August 31, 2023 06:02
findinpath
findinpath reviewed Aug 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@findinpath findinpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea.

Comment thread plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java Outdated
Comment thread plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java Outdated
@ebyhr ebyhr force-pushed the ebi/delta-move-pt branch from d786ecf to 147c028 Compare August 31, 2023 23:01
@ebyhr ebyhr merged commit 55bb455 into master Sep 1, 2023
@ebyhr ebyhr deleted the ebi/delta-move-pt branch September 1, 2023 23:03
@github-actions github-actions bot added this to the 426 milestone Sep 1, 2023
@colebow colebow mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findepi findepi findepi approved these changes

@homar homar Awaiting requested review from homar

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

@pajaks pajaks Awaiting requested review from pajaks

+1 more reviewer

@findinpath findinpath findinpath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed delta-lake Delta Lake connector

Milestone

426

Development

Successfully merging this pull request may close these issues.

3 participants

@ebyhr @findepi @findinpath