Skip to content

Fix NPE when checking is materialized hive view #18800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jinyangli34 wants to merge 1 commit into from
Closed

Fix NPE when checking is materialized hive view #18800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/trino-hive/src/main/java/io/trino/plugin/hive/ViewReaderUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public static boolean isTrinoMaterializedView(String tableType, Map<String, Stri
// https://github.com/trinodb/trino/blame/ff4a1e31fb9cb49f1b960abfc16ad469e7126a64/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java#L898
return tableType.equals(VIRTUAL_VIEW.name()) &&
"true".equals(tableParameters.get(PRESTO_VIEW_FLAG)) &&
tableParameters.get(TABLE_COMMENT).equalsIgnoreCase(ICEBERG_MATERIALIZED_VIEW_COMMENT);
ICEBERG_MATERIALIZED_VIEW_COMMENT.equalsIgnoreCase(tableParameters.get(TABLE_COMMENT));
Copy link
Copy Markdown
Member

@ebyhr ebyhr Aug 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test?

Don't we need to fix isTrinoView method as well?

Copy link
Copy Markdown
Contributor

@findinpath findinpath Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the same handling on https://github.com/trinodb/trino/pull/18800/files/520d9b200b12e54120560da22dcf14b9dd8d7c75#diff-ce243e62b3d6f2ba7a3afb20e69702c55ce47b7579e66391d3a96b42605cb4e3R171

}

public static String encodeViewData(ConnectorViewDefinition definition)
Expand Down