Skip to content

Allow writing to externally provided JDK#18797

Merged
wendigo merged 1 commit intotrinodb:masterfrom
wendigo:serafin/jdk-provider-mount
Aug 24, 2023
Merged

Allow writing to externally provided JDK#18797
wendigo merged 1 commit intotrinodb:masterfrom
wendigo:serafin/jdk-provider-mount

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented Aug 24, 2023

Some product test environments can import certificates to cacerts, which will fail if the externally provided JDK is mounted read-only.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Some product test environments can import certificates to cacerts,
which will fail if the externally provided JDK is mounted read-only.
@cla-bot cla-bot bot added the cla-signed label Aug 24, 2023
@wendigo wendigo requested a review from raunaqmorarka August 24, 2023 13:09
@wendigo wendigo requested a review from kokosing August 24, 2023 13:11
@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Aug 24, 2023

I've verified locally that the custom JDK is mounted read-writeable:

        "Mounts": [
            {
                "Type": "bind",
                "Source": "/Users/mateuszgajewski/Projects/src/github.com/trinodb/trino/core/trino-server/target/trino-server-425-SNAPSHOT.tar.gz",
                "Destination": "/docker/presto-server.tar.gz",
                "Mode": "ro",
                "RW": false,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Source": "/var/folders/n4/vl45d5rn5n1_yk_pl5xkpd380000gn/T/ptl-tmp-download/zulu21-ea-arm64/zulu21.0.57-ea-jdk21.0.0-ea.22-linux_aarch64",
                "Destination": "/usr/lib/jvm/zulu21-ea",
                "Mode": "rw",
                "RW": true,
                "Propagation": "rprivate"
            }
        ],

@wendigo wendigo merged commit f946757 into trinodb:master Aug 24, 2023
@wendigo wendigo deleted the serafin/jdk-provider-mount branch August 24, 2023 15:44
@github-actions github-actions bot added this to the 425 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants