Add support for TRUNCATE TABLE statement in Delta Lake#18788
Merged
Conversation
ebyhr
force-pushed
the
ebi/delta-truncate
branch
3 times, most recently
from
4473e9f to
649021f
Compare
Member
Author
|
suite-delta-lake-databricks113 hit timeout #18805 |
ebyhr
force-pushed
the
ebi/delta-truncate
branch
from
649021f to
548d664
Compare
findinpath
approved these changes
Aug 28, 2023
findinpath
reviewed
Aug 28, 2023
| public static final String MERGE_OPERATION = "MERGE"; | ||
| public static final String UPDATE_OPERATION = "UPDATE"; // used by old Trino versions and Spark | ||
| public static final String DELETE_OPERATION = "DELETE"; // used Trino for whole table/partition deletes as well as Spark | ||
| public static final String TRUNCATE_OPERATION = "TRUNCATE"; |
Contributor
There was a problem hiding this comment.
A small note about MERGE could be added to https://trino.io/docs/current/connector/delta-lake.html#delta-lake-data-management
findepi
approved these changes
Aug 28, 2023
| SUPPORTS_SET_COLUMN_TYPE, | ||
| SUPPORTS_TOPN_PUSHDOWN, | ||
| SUPPORTS_TRUNCATE -> false; | ||
| SUPPORTS_TOPN_PUSHDOWN -> false; |
Member
There was a problem hiding this comment.
this shouldn't use enhanced switch (so that single item modification is a single line change, not two)
Member
There was a problem hiding this comment.
oh, i see this was recently changed and discussed here #18783 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18786
Release notes
(x) Release notes are required, with the following suggested text: