Allow re-using Oracle container in tests#18774
Merged
wendigo merged 1 commit intotrinodb:masterfrom Aug 22, 2023
Merged
Conversation
wendigo
approved these changes
Aug 22, 2023
hashhar
approved these changes
Aug 22, 2023
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % editorials
Can you reformat commit message: Allow re-using Oracle container in tests
And add the context about the previous commit/changes in the commit message itself (the thing which you've mentioned in the PR description).
dominikzalewski
changed the title
dominikzalewski
force-pushed
the
test_container_reuse_oracle
branch
from
b30eeb9 to
389306a
Compare
Member
Author
Yes. Done in PR itself and in the commit message header line as well.
Done like you asked. |
Member
|
Thanks, will merge once CI is finished. |
Ability to iterate faster on integration test development for Oracle by adding the support for TESTCONTAINERS_REUSE_ENABLE environment variable. This is based on previous commit fbd1de0 by @kokosing, which adds the feature and enables it for SQL Server and MySQL. Based on further comments from @kokosing, enablement of this feature for specific database tests needs to be tested one-by-one as not all test containers seem to digest that change without problems. This justifies adding it iteratively for selected databases based on a need-to-use basis.
dominikzalewski
force-pushed
the
test_container_reuse_oracle
branch
from
389306a to
71afdf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ability to iterate faster on integration test development for Oracle by adding the support for TESTCONTAINERS_REUSE_ENABLE environment variable.
Additional context and related issues
This is based on previous commit
fbd1de0
by @kokosing, which adds the feature and enables it for SQL Server and MySQL. Based on further comments from @kokosing, enablement of this feature for specific database tests needs to be tested one-by-one as not all test containers seem to digest that change without problems. This justifies adding it iteratively for selected databases based on a need-to-use basis.
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: