Merged
Conversation
losipiuk
reviewed
Aug 22, 2023
core/trino-main/src/main/java/io/trino/operator/ChannelSet.java
Outdated
Show resolved
Hide resolved
martint
approved these changes
Aug 22, 2023
core/trino-main/src/main/java/io/trino/operator/ChannelSet.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/ChannelSet.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Convert ChannelSet used in SemiJoinOperator from GroupByHash to the new FlatSet. The FlatSet is deisgned for the single write, multi-threaded read that ChannelSet uses. The FlatSet is much simpler as it only needs to hold a single column, and only needs to support a contains check, which vastly simplifies the implementation.
This effectivly splits the use cases of GroupByHash, so the contains methods can be used.
Fixes #18752
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.