Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugin/trino-cassandra/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@
<artifactId>units</artifactId>
</dependency>

<dependency>
<groupId>io.opentelemetry.instrumentation</groupId>
<artifactId>opentelemetry-cassandra-4.4</artifactId>
</dependency>

<dependency>
<groupId>io.trino</groupId>
<artifactId>trino-plugin-toolkit</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
import com.google.inject.Scopes;
import com.google.inject.Singleton;
import io.airlift.json.JsonCodec;
import io.opentelemetry.api.OpenTelemetry;
import io.opentelemetry.instrumentation.cassandra.v4_4.CassandraTelemetry;
import io.trino.plugin.cassandra.ptf.Query;
import io.trino.spi.TrinoException;
import io.trino.spi.function.table.ConnectorTableFunction;
Expand Down Expand Up @@ -110,7 +112,11 @@ protected Type _deserialize(String value, DeserializationContext context)

@Singleton
@Provides
public static CassandraSession createCassandraSession(CassandraTypeManager cassandraTypeManager, CassandraClientConfig config, JsonCodec<List<ExtraColumnMetadata>> extraColumnMetadataCodec)
public static CassandraSession createCassandraSession(
CassandraTypeManager cassandraTypeManager,
CassandraClientConfig config,
JsonCodec<List<ExtraColumnMetadata>> extraColumnMetadataCodec,
OpenTelemetry openTelemetry)
{
requireNonNull(extraColumnMetadataCodec, "extraColumnMetadataCodec is null");

Expand Down Expand Up @@ -177,7 +183,8 @@ public static CassandraSession createCassandraSession(CassandraTypeManager cassa
() -> {
contactPoints.forEach(contactPoint -> cqlSessionBuilder.addContactPoint(
createInetSocketAddress(contactPoint, config.getNativeProtocolPort())));
return cqlSessionBuilder.build();
CassandraTelemetry cassandraTelemetry = CassandraTelemetry.create(openTelemetry);
return cassandraTelemetry.wrap(cqlSessionBuilder.build());
},
config.getNoHostAvailableRetryTimeout());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import com.google.inject.Injector;
import io.airlift.bootstrap.Bootstrap;
import io.airlift.json.JsonModule;
import io.opentelemetry.api.OpenTelemetry;
import io.trino.plugin.base.jmx.MBeanServerModule;
import io.trino.spi.connector.Connector;
import io.trino.spi.connector.ConnectorContext;
Expand Down Expand Up @@ -43,6 +44,7 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
checkStrictSpiVersionMatch(context, this);

Bootstrap app = new Bootstrap(
binder -> binder.bind(OpenTelemetry.class).toInstance(context.getOpenTelemetry()),
new MBeanModule(),
new JsonModule(),
new CassandraClientModule(context.getTypeManager()),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.base.Throwables;
import com.google.common.collect.ImmutableList;
import com.google.inject.Inject;
import com.google.inject.Provider;
Expand All @@ -24,6 +25,7 @@
import io.trino.plugin.cassandra.CassandraMetadata;
import io.trino.plugin.cassandra.CassandraQueryRelationHandle;
import io.trino.plugin.cassandra.CassandraTableHandle;
import io.trino.spi.TrinoException;
import io.trino.spi.connector.ColumnHandle;
import io.trino.spi.connector.ConnectorAccessControl;
import io.trino.spi.connector.ConnectorSession;
Expand All @@ -38,13 +40,15 @@
import io.trino.spi.function.table.ScalarArgumentSpecification;
import io.trino.spi.function.table.TableFunctionAnalysis;

import java.lang.reflect.UndeclaredThrowableException;
import java.util.List;
import java.util.Map;
import java.util.Optional;

import static com.google.common.base.Preconditions.checkState;
import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.collect.Iterables.getOnlyElement;
import static io.trino.spi.StandardErrorCode.INVALID_FUNCTION_ARGUMENT;
import static io.trino.spi.function.table.ReturnTypeSpecification.GenericTable.GENERIC_TABLE;
import static io.trino.spi.type.VarcharType.VARCHAR;
import static java.util.Objects.requireNonNull;
Expand Down Expand Up @@ -98,7 +102,13 @@ public TableFunctionAnalysis analyze(
String query = ((Slice) argument.getValue()).toStringUtf8();

CassandraQueryRelationHandle queryRelationHandle = new CassandraQueryRelationHandle(query);
List<ColumnHandle> columnHandles = cassandraMetadata.getColumnHandles(query);
List<ColumnHandle> columnHandles;
try {
columnHandles = cassandraMetadata.getColumnHandles(query);
}
catch (UndeclaredThrowableException e) {
throw new TrinoException(INVALID_FUNCTION_ARGUMENT, "Cannot get column definition", Throwables.getRootCause(e));
}
checkState(!columnHandles.isEmpty(), "Handle doesn't have columns info");
Descriptor returnedType = new Descriptor(columnHandles.stream()
.map(CassandraColumnHandle.class::cast)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1463,7 +1463,8 @@ public void testNativeQueryPreparingStatementFailure()
String tableName = "test_insert" + randomNameSuffix();
assertFalse(getQueryRunner().tableExists(getSession(), tableName));
assertThatThrownBy(() -> query("SELECT * FROM TABLE(cassandra.system.query(query => 'INSERT INTO tpch." + tableName + "(col) VALUES (1)'))"))
.hasMessageContaining("unconfigured table");
.hasMessage("Cannot get column definition")
.hasStackTraceContaining("unconfigured table");
}

@Test
Expand All @@ -1490,7 +1491,8 @@ public void testNativeQueryUnsupportedStatement()
public void testNativeQueryIncorrectSyntax()
{
assertThatThrownBy(() -> query("SELECT * FROM TABLE(system.query(query => 'some wrong syntax'))"))
.hasMessageContaining("no viable alternative at input 'some'");
.hasMessage("Cannot get column definition")
.hasStackTraceContaining("no viable alternative at input 'some'");
}

@Override
Expand Down