-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add support for OpenTelemetry in JDBC connectors #18735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124 changes: 124 additions & 0 deletions
124
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/TracingDataSource.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.jdbc; | ||
|
|
||
| import io.opentelemetry.api.OpenTelemetry; | ||
| import io.opentelemetry.instrumentation.jdbc.datasource.OpenTelemetryDataSource; | ||
|
|
||
| import javax.sql.DataSource; | ||
|
|
||
| import java.io.PrintWriter; | ||
| import java.sql.Connection; | ||
| import java.sql.Driver; | ||
| import java.sql.SQLException; | ||
| import java.util.Properties; | ||
| import java.util.logging.Logger; | ||
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class TracingDataSource | ||
| { | ||
| private final OpenTelemetry openTelemetry; | ||
| private final Driver driver; | ||
| private final String connectionUrl; | ||
|
|
||
| public TracingDataSource(OpenTelemetry openTelemetry, Driver driver, String connectionUrl) | ||
| { | ||
| this.openTelemetry = requireNonNull(openTelemetry, "openTelemetry is null"); | ||
| this.driver = requireNonNull(driver, "driver is null"); | ||
| this.connectionUrl = requireNonNull(connectionUrl, "connectionUrl is null"); | ||
| } | ||
|
|
||
| public Connection getConnection(Properties properties) | ||
| throws SQLException | ||
| { | ||
| DataSource dataSource = new JdbcDataSource(driver, connectionUrl, properties); | ||
| try (OpenTelemetryDataSource openTelemetryDataSource = new OpenTelemetryDataSource(dataSource, openTelemetry)) { | ||
| return openTelemetryDataSource.getConnection(); | ||
| } | ||
| catch (Exception e) { | ||
| throw new SQLException(e); | ||
| } | ||
| } | ||
|
|
||
| private static class JdbcDataSource | ||
| implements DataSource | ||
| { | ||
| private final Driver driver; | ||
| private final String connectionUrl; | ||
| private final Properties properties; | ||
|
|
||
| public JdbcDataSource(Driver driver, String connectionUrl, Properties properties) | ||
| { | ||
| this.driver = requireNonNull(driver, "driver is null"); | ||
| this.connectionUrl = requireNonNull(connectionUrl, "connectionUrl is null"); | ||
| this.properties = requireNonNull(properties, "properties is null"); | ||
| } | ||
|
|
||
| @Override | ||
| public Connection getConnection() | ||
| throws SQLException | ||
| { | ||
| return driver.connect(connectionUrl, properties); | ||
| } | ||
|
|
||
| @Override | ||
| public Connection getConnection(String username, String password) | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public PrintWriter getLogWriter() | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public void setLogWriter(PrintWriter out) | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public void setLoginTimeout(int seconds) | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public int getLoginTimeout() | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public Logger getParentLogger() | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public <T> T unwrap(Class<T> iface) | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isWrapperFor(Class<?> iface) | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.