Skip to content

Remove writer config overrides in scale writer tests #18700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raunaqmorarka merged 1 commit into from
Aug 17, 2023
Merged

Remove writer config overrides in scale writer tests #18700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseHiveConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4082,7 +4082,6 @@ private void testMultipleWriters(Session session, HiveStorageFormat storageForma
.setSystemProperty("scale_writers", "true")
.setSystemProperty("task_scale_writers_enabled", "false")
.setSystemProperty("writer_scaling_min_data_processed", "1MB")
.setCatalogSessionProperty(catalog, "parquet_writer_block_size", "4MB")
.build(),
createTableSql,
(long) computeActual("SELECT count(*) FROM tpch.sf1.orders").getOnlyValue());
Expand Down Expand Up @@ -4113,7 +4112,6 @@ private void testMultipleWritersWithSkewedData(Session session, HiveStorageForma
.setSystemProperty("task_scale_writers_enabled", "false")
.setSystemProperty("writer_scaling_min_data_processed", "1MB")
.setSystemProperty("join_distribution_type", "PARTITIONED")
.setCatalogSessionProperty(catalog, "parquet_writer_block_size", "4MB")
.build(),
createTableSql,
(long) computeActual("SELECT count(*) FROM (" + selectSql + ")")
Expand Down Expand Up @@ -4234,10 +4232,6 @@ protected AbstractLongAssert<?> testTaskScaleWriters(
.setSystemProperty(FAULT_TOLERANT_EXECUTION_ARBITRARY_DISTRIBUTION_WRITE_TASK_TARGET_SIZE_MAX, "2GB")
.setSystemProperty(FAULT_TOLERANT_EXECUTION_HASH_DISTRIBUTION_COMPUTE_TASK_TARGET_SIZE, "2GB")
.setSystemProperty(FAULT_TOLERANT_EXECUTION_HASH_DISTRIBUTION_WRITE_TASK_TARGET_SIZE, "2GB")
// Set the value of orc strip size low to increase the frequency at which
// physicalWrittenDataSize is updated through ConnectorPageSink#getCompletedBytes()
.setCatalogSessionProperty(catalog, "orc_optimized_writer_min_stripe_size", "2MB")
.setCatalogSessionProperty(catalog, "orc_optimized_writer_max_stripe_size", "2MB")
.build(),
createTableSql,
(long) computeActual("SELECT count(*) FROM tpch.sf5.orders").getOnlyValue());
Expand Down