Skip to content

Add support for DROP SCHEMA CASCADE in Iceberg connector #18689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Aug 16, 2023
Merged

Add support for DROP SCHEMA CASCADE in Iceberg connector #18689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca112f8
Add support for DROP SCHEMA CASCADE in Iceberg connector
ebyhr Aug 16, 2023
abfb87d
empty
findepi Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,8 +718,19 @@ public void createSchema(ConnectorSession session, String schemaName, Map<String
}

@Override
public void dropSchema(ConnectorSession session, String schemaName)
public void dropSchema(ConnectorSession session, String schemaName, boolean cascade)
{
if (cascade) {
for (SchemaTableName materializedView : listMaterializedViews(session, Optional.of(schemaName))) {
dropMaterializedView(session, materializedView);
}
for (SchemaTableName viewName : listViews(session, Optional.of(schemaName))) {
dropView(session, viewName);
}
for (SchemaTableName tableName : listTables(session, Optional.of(schemaName))) {
dropTable(session, getTableHandle(session, tableName, Optional.empty(), Optional.empty()));
}
}
catalog.dropNamespace(session, schemaName);
}

Expand Down
3 changes: 0 additions & 3 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,6 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
case SUPPORTS_TOPN_PUSHDOWN:
return false;

case SUPPORTS_DROP_SCHEMA_CASCADE:
return false;

case SUPPORTS_RENAME_MATERIALIZED_VIEW_ACROSS_SCHEMAS:
return false;

Expand Down