Small cleanup in BaseHiveConnectorTest / TestHiveConnectorTest#18669
Merged
findepi merged 6 commits intotrinodb:masterfrom Aug 14, 2023
Merged
Small cleanup in BaseHiveConnectorTest / TestHiveConnectorTest#18669findepi merged 6 commits intotrinodb:masterfrom
findepi merged 6 commits intotrinodb:masterfrom
Conversation
Base test class should provide tests, but setup should be left up to the concrete classes.
The tests `testBucketedTable`, `testCreatePartitionedBucketedTableAsFewRows`, `testInsertPartitionedBucketedTableFewRows` were taking a test session but the ignoring it, using whatever `getParallelWriteSession` produces. The commit makes the latter method accept a base session to configure from.
Utilize existing test helper for iterating over storage formats. The method structure is picked after `testBucketedTable`.
Utilize existing test helper for iterating over storage formats.
Utilize existing test helper for iterating over storage formats.
findepi
added
test
no-release-notes
losipiuk
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.