Skip to content

Add support for DROP SCHEMA CASCADE in Memory connector #18668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Aug 15, 2023
Merged

Add support for DROP SCHEMA CASCADE in Memory connector #18668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
import static com.google.common.base.Verify.verify;
import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.collect.ImmutableMap.toImmutableMap;
import static com.google.common.collect.ImmutableSet.toImmutableSet;
import static io.trino.spi.StandardErrorCode.ALREADY_EXISTS;
import static io.trino.spi.StandardErrorCode.NOT_FOUND;
import static io.trino.spi.StandardErrorCode.SCHEMA_NOT_EMPTY;
Expand Down Expand Up @@ -111,12 +112,24 @@ public synchronized void createSchema(ConnectorSession session, String schemaNam
}

@Override
public synchronized void dropSchema(ConnectorSession session, String schemaName)
public synchronized void dropSchema(ConnectorSession session, String schemaName, boolean cascade)
{
if (!schemas.contains(schemaName)) {
throw new TrinoException(NOT_FOUND, format("Schema [%s] does not exist", schemaName));
}

if (cascade) {
Set<SchemaTableName> viewNames = views.keySet().stream()
.filter(view -> view.getSchemaName().equals(schemaName))
.collect(toImmutableSet());
viewNames.forEach(viewName -> dropView(session, viewName));

Set<SchemaTableName> tableNames = tables.values().stream()
.filter(table -> table.getSchemaName().equals(schemaName))
.map(TableInfo::getSchemaTableName)
.collect(toImmutableSet());
tableNames.forEach(tableName -> dropTable(session, getTableHandle(session, tableName)));
}
// DropSchemaTask has the same logic, but needs to check in connector side considering concurrent operations
if (!isSchemaEmpty(schemaName)) {
throw new TrinoException(SCHEMA_NOT_EMPTY, "Schema not empty: " + schemaName);
Expand Down
1 change: 0 additions & 1 deletion plugin/trino-memory/src/test/java/io/trino/plugin/memory/TestMemoryConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
return false;

case SUPPORTS_RENAME_SCHEMA:
case SUPPORTS_DROP_SCHEMA_CASCADE:
return false;

case SUPPORTS_ADD_COLUMN:
Expand Down