Store physical partition name in Delta CREATE TABLE AS SELECT#18662
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Aug 28, 2023
Merged
Store physical partition name in Delta CREATE TABLE AS SELECT#18662ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
ebyhr
force-pushed
the
ebi/delta-ctas-partition
branch
from
c690881 to
dbe6df0
Compare
Also, fix dropColumn method to avoid name base matching.
ebyhr
force-pushed
the
ebi/delta-ctas-partition
branch
from
dbe6df0 to
4021c4b
Compare
findinpath
approved these changes
Aug 14, 2023
| ColumnMappingMode columnMappingMode = handle.getColumnMappingMode(); | ||
| String schemaString = handle.getSchemaString(); | ||
| List<String> columnNames = handle.getInputColumns().stream().map(DeltaLakeColumnHandle::getBaseColumnName).collect(toImmutableList()); | ||
| List<String> physicalPartitionNames = handle.getInputColumns().stream() |
Contributor
There was a problem hiding this comment.
This seems to be something we didn't consider in #12638
I don't see at the moment any further related open issues.
pajaks
approved these changes
Aug 21, 2023
alexjo2144
reviewed
Aug 21, 2023
| handle.getComment(), | ||
| handle.getProtocolEntry()); | ||
| appendAddFileEntries(transactionLogWriter, dataFileInfos, handle.getPartitionedBy(), columnNames, true); | ||
| appendAddFileEntries(transactionLogWriter, dataFileInfos, physicalPartitionNames, columnNames, true); |
Member
There was a problem hiding this comment.
What about a couple lines up in the appendTableEntries call, should we use physicalPartitionNames there too?
Member
Author
There was a problem hiding this comment.
Do you mean handle.getPartitionedBy() for partitionColumns in metaData? The current implementation is same as OSS Delta Lake. They store non-physical partition column names in the field.
findepi
approved these changes
Aug 28, 2023
alexjo2144
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18661
Release notes
(x) Release notes are required, with the following suggested text: