Require the JVM default charset is UTF-8#18657
Merged
dain merged 1 commit intotrinodb:masterfrom Aug 12, 2023
Merged
Conversation
electrum
approved these changes
Aug 11, 2023
core/trino-main/src/main/java/io/trino/server/TrinoSystemRequirements.java
Outdated
Show resolved
Hide resolved
Member
|
Should we update the docs to include that info? |
Member
Author
@mosabua Yes. Where is that? |
Java changed the default charset to UTF-8 in JEP 400 which is in Java 19
Member
Author
|
@mosabua docs added |
mosabua
approved these changes
Aug 11, 2023
Member
mosabua
left a comment
There was a problem hiding this comment.
Docs are good even though we officially talk about just using 17 .. its still good to have.
Member
Author
When we move to 21 in a few months, we need to rewrite a bunch of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java changed the default charset to UTF-8 in JEP 400 which is in Java 19
The error message is:
Release notes
( ) Release notes are required, with the following suggested text: