Skip to content

Add recommendation for Hive views#18655

Merged
mosabua merged 1 commit intotrinodb:masterfrom
simpligility:hive-views
Aug 31, 2023
Merged

Add recommendation for Hive views#18655
mosabua merged 1 commit intotrinodb:masterfrom
simpligility:hive-views

Conversation

@mosabua
Copy link
Copy Markdown
Member

@mosabua mosabua commented Aug 11, 2023

Description

The current documentation is not explicit about any recommendation. I think it is fair to add the suggested paragraph. This keeps coming up in conversations with user as not being clear.

In addition I think we might have to update some of the limitations in the section about experimental mode .. but I am not sure about details.

Also ... could we rename the experimental mode to some other name?

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Aug 11, 2023

Also .. wdyt @kpayne

@github-actions github-actions bot added the docs label Aug 11, 2023
@findinpath
Copy link
Copy Markdown
Contributor

could we rename the experimental mode to some other name?

Code-wise the setting is called now hive.hive-views.enabled

@LegacyConfig({"hive.views-execution.enabled", "hive.translate-hive-views"})
@Config(HIVE_VIEWS_ENABLED)
@ConfigDescription("Experimental: Allow translation of Hive views into Trino views")
public HiveConfig setTranslateHiveViews(boolean translateHiveViews)

What is left is to replace the wording on https://trino.io/docs/current/connector/hive.html#hive-views
We just need to find a better name than Experimental

e.g. : Translation or (from chat gpt) Conversion

Comment thread docs/src/main/sphinx/connector/hive.rst Outdated
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Aug 29, 2023

Rebased to the md file now .. any suggestions on how to proceed in this PR without expanding scope to cover Trino views and more? Could we just merge and follow up since this is useful content on its own @findinpath @findepi @alexjo2144 ?

Comment thread docs/src/main/sphinx/connector/hive.md Outdated
Comment thread docs/src/main/sphinx/connector/hive.md Outdated
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Aug 31, 2023

Is this good now @ebyhr @findinpath ?

@mosabua mosabua merged commit 98de907 into trinodb:master Aug 31, 2023
@mosabua mosabua deleted the hive-views branch August 31, 2023 22:15
@github-actions github-actions bot added this to the 426 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants