Skip to content

Remove unused methods in CachingHiveMetastore #18641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Aug 11, 2023
Merged

Remove unused methods in CachingHiveMetastore #18641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ...n/trino-hive/src/main/java/io/trino/plugin/hive/metastore/cache/CachingHiveMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
import io.trino.plugin.hive.metastore.UserTableKey;
import io.trino.spi.TrinoException;
import io.trino.spi.connector.SchemaTableName;
import io.trino.spi.connector.TableNotFoundException;
import io.trino.spi.predicate.TupleDomain;
import io.trino.spi.security.RoleGrant;
import io.trino.spi.type.Type;
Expand Down Expand Up @@ -591,12 +590,6 @@ private List<String> loadAllDatabases()
return delegate.getAllDatabases();
}

private Table getExistingTable(String databaseName, String tableName)
{
return getTable(databaseName, tableName)
.orElseThrow(() -> new TableNotFoundException(new SchemaTableName(databaseName, tableName)));
}

@Override
public Optional<Table> getTable(String databaseName, String tableName)
{
Expand Down Expand Up @@ -636,12 +629,6 @@ public PartitionStatistics getTableStatistics(Table table)
CachingHiveMetastore::mergePartitionColumnStatistics);
}

private PartitionStatistics loadTableColumnStatistics(HiveTableName tableName)
{
Table table = getExistingTable(tableName.getDatabaseName(), tableName.getTableName());
return delegate.getTableStatistics(table);
}

/**
* The method will cache and return columns specified in the {@link Table#getDataColumns()}
* but may return more if other columns are already cached for a given partition.
Expand Down